Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ThreadLocalAccessor for WebClient in Spring Boot 3 sample #2568

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Feb 24, 2023

#skip-changelog

📜 Description

Use ThreadLocalAccessor for WebClient in Spring Boot 3 sample

💡 Motivation and Context

To showcase how it can be used.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@adinauer adinauer changed the base branch from main to feat/use-thread-local-accessor-in-webflux-sample February 24, 2023 10:57
@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against d3f277b

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 356.08 ms 382.81 ms 26.73 ms
Size 1.73 MiB 2.34 MiB 626.30 KiB

Baseline results on branch: feat/use-thread-local-accessor-in-webflux-sample

Startup times

Revision Plain With Sentry Diff
2e82a91 301.84 ms 359.88 ms 58.04 ms
02d7ab6 307.38 ms 333.83 ms 26.45 ms
09f597a 284.63 ms 359.79 ms 75.16 ms

App size

Revision Plain With Sentry Diff
2e82a91 1.73 MiB 2.34 MiB 626.30 KiB
02d7ab6 1.73 MiB 2.34 MiB 626.30 KiB
09f597a 1.73 MiB 2.34 MiB 626.30 KiB

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9a2d1a4) 80.35% compared to head (bd5f90e) 80.35%.

❗ Current head bd5f90e differs from pull request most recent head d3f277b. Consider uploading reports for the commit d3f277b to get more accurate results

Additional details and impacted files
@@                                 Coverage Diff                                 @@
##             feat/use-thread-local-accessor-in-webflux-sample    #2568   +/-   ##
===================================================================================
  Coverage                                               80.35%   80.35%           
  Complexity                                               4011     4011           
===================================================================================
  Files                                                     332      332           
  Lines                                                   15148    15148           
  Branches                                                 1979     1979           
===================================================================================
  Hits                                                    12172    12172           
  Misses                                                   2197     2197           
  Partials                                                  779      779           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adinauer adinauer merged commit 8a02340 into feat/use-thread-local-accessor-in-webflux-sample Mar 1, 2023
@adinauer adinauer deleted the feat/use-thread-local-accessor-for-webclient branch March 1, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants