Use the same hub in WebFlux exception handler as we do in WebFilter

[adinauer]

📜 Description

Pass hub from WebFilter to SentryWebExceptionHandler via ServerWebExchange attributes.

💡 Motivation and Context

We just used whatever hub is there which could possibly bleed into other requests.

💚 How did you test it?

Manually with debugger

📝 Checklist

• I reviewed the submitted code.
• I added tests to verify the changes.
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
• I updated the docs if needed.
• Review from the native team if needed.
• No breaking change or entry added to the changelog.
• No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	450.33 ms	514.50 ms	64.17 ms
Size	1.73 MiB	2.34 MiB	626.31 KiB

Baseline results on branch: feat/reactor-with-sentry-continue-or-fresh

Startup times

Revision	Plain	With Sentry	Diff
a98c90a	293.96 ms	333.90 ms	39.94 ms
a864e2f	353.66 ms	392.94 ms	39.28 ms
b300cf4	371.66 ms	401.00 ms	29.34 ms

App size

Revision	Plain	With Sentry	Diff
a98c90a	1.73 MiB	2.34 MiB	626.31 KiB
a864e2f	1.73 MiB	2.34 MiB	626.31 KiB
b300cf4	1.73 MiB	2.34 MiB	626.31 KiB

Previous results on branch: fix/use-request-hub-in-webflux-exception-handler

Startup times

Revision	Plain	With Sentry	Diff
165ee8a	336.26 ms	378.39 ms	42.13 ms
8da9be7	321.31 ms	385.62 ms	64.31 ms

App size

Revision	Plain	With Sentry	Diff
165ee8a	1.73 MiB	2.34 MiB	626.31 KiB
8da9be7	1.73 MiB	2.34 MiB	626.31 KiB

[codecov]

Codecov Report

Base: 80.41% // Head: 80.41% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (4b7f848) compared to base (1947daf).
Patch coverage: 90.00% of modified lines in pull request are covered.

Additional details and impacted files

@@                              Coverage Diff                              @@
##             feat/reactor-with-sentry-continue-or-fresh    #2566   +/-   ##
=============================================================================
  Coverage                                         80.41%   80.41%           
- Complexity                                         4020     4022    +2     
=============================================================================
  Files                                               332      332           
  Lines                                             15155    15161    +6     
  Branches                                           1979     1980    +1     
=============================================================================
+ Hits                                              12187    12192    +5     
  Misses                                             2189     2189           
- Partials                                            779      780    +1     

Impacted Files	Coverage Δ
...ing/jakarta/webflux/SentryWebExceptionHandler.java	90.90% <89.47%> (-3.21%)	⬇️
...sentry/spring/jakarta/webflux/SentryWebFilter.java	95.45% <100.00%> (+0.21%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[adinauer]

This should probably also be done for Spring Boot 2

[adinauer]

Let's not do it in this PR. I'm afraid adding it there might make things worse. If we clone a new hub from main hub we might end up with static calls during requests that end up in different (non parent - child) hubs. Maybe ThreadLocalAccessor is added to Spring Boot 2 at some point.

[adinauer]

Load test confirms problems: WARNING: Attempt to pop the root scope.