-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore Shutdown in progress when closing ShutdownHookIntegration #2521
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c1399c1 | 345.06 ms | 385.49 ms | 40.43 ms |
f6a135d | 263.96 ms | 383.59 ms | 119.63 ms |
5fa24ec | 326.29 ms | 384.53 ms | 58.24 ms |
14c083a | 350.82 ms | 388.86 ms | 38.04 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c1399c1 | 1.73 MiB | 2.33 MiB | 620.61 KiB |
f6a135d | 1.73 MiB | 2.33 MiB | 623.10 KiB |
5fa24ec | 1.73 MiB | 2.33 MiB | 620.61 KiB |
14c083a | 1.73 MiB | 2.33 MiB | 620.61 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Markus Hintersteiner <[email protected]>
Codecov ReportBase: 80.18% // Head: 80.18% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2521 +/- ##
============================================
- Coverage 80.18% 80.18% -0.01%
- Complexity 3942 3943 +1
============================================
Files 323 323
Lines 14891 14896 +5
Branches 1964 1965 +1
============================================
+ Hits 11940 11944 +4
Misses 2178 2178
- Partials 773 774 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
📜 Description
Ignore "Shutdown in progress"
IllegalStateException
when removing the shutdown hook. This was also present in older versions of the SDK (https://github.com/getsentry/sentry-java/pull/550/files).💡 Motivation and Context
Came up again recently in #2465 and also happened in tests before #1574 and #1663
💚 How did you test it?
Unit Test
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps