Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sentry BOM containing wrong artifacts #2504

Merged
merged 3 commits into from
Jan 31, 2023
Merged

Fix Sentry BOM containing wrong artifacts #2504

merged 3 commits into from
Jan 31, 2023

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jan 31, 2023

📜 Description

sentry-bom was containing wrong artifacts (e.g. test dependencies, test apps, missing compose artifacts, etc.). This PR fixes it.

💡 Motivation and Context

Closes #2503

💚 How did you test it?

Manually ./gradlew publishToMavenLocal. The result can be checked here
sentry-bom-6.13.0.txt

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed
  • No breaking changes

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2023

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Fix Sentry BOM containing wrong artifacts ([#2504](https://github.com/getsentry/sentry-java/pull/2504))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 5668e5d

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@romtsn romtsn enabled auto-merge (squash) January 31, 2023 08:07
@romtsn romtsn merged commit c1399c1 into main Jan 31, 2023
@romtsn romtsn deleted the fix/sentry-bom branch January 31, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants