-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create timer in TransactionPerformanceCollector
lazily
#2478
Conversation
TransactionPerformanceCollector
lazily
Performance metrics 🚀
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jeez, here we are again with the Timer stuff :D can we write an integration test that checks for shutdown of a backend app somehow?
Codecov ReportBase: 80.14% // Head: 80.13% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2478 +/- ##
============================================
- Coverage 80.14% 80.13% -0.01%
- Complexity 3872 3873 +1
============================================
Files 312 312
Lines 14669 14672 +3
Branches 1941 1943 +2
============================================
+ Hits 11756 11758 +2
Misses 2153 2153
- Partials 760 761 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Yeah we should. Created #2479 so we don't forget. |
📜 Description
Timer was created even if performance wasn't enabled. Also Timer prevented shutdown.
💡 Motivation and Context
Fixes #2477
💚 How did you test it?
📝 Checklist
🔮 Next steps