Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer disable OpenTelemetry exporters in default Java Agent config #2408

Merged
merged 3 commits into from
Dec 2, 2022

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Dec 2, 2022

📜 Description

Restore default exporter configuration for Sentry OpenTelemetry Java Agent.

💡 Motivation and Context

To not confuse users who could use the Sentry Java Agent as drop in replacement for the original OpenTelemetry Java Agent we want to keep the default exporter settings and document how to get rid of ERROR messages in the logs.

💚 How did you test it?

Manually

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 567d7e9

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 330.58 ms 339.88 ms 9.30 ms
Size 1.73 MiB 2.32 MiB 612.39 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
90e9745 314.68 ms 357.28 ms 42.60 ms
7597ded 289.60 ms 339.69 ms 50.09 ms
4a9c176 320.62 ms 334.68 ms 14.06 ms
3695453 301.78 ms 371.14 ms 69.36 ms
7967d22 289.28 ms 377.11 ms 87.83 ms
3695453 314.63 ms 353.10 ms 38.47 ms
4a9c176 319.77 ms 363.20 ms 43.43 ms
3695453 299.25 ms 360.04 ms 60.79 ms
a04f788 321.78 ms 354.12 ms 32.35 ms
16371c5 314.02 ms 394.54 ms 80.52 ms

App size

Revision Plain With Sentry Diff
90e9745 1.73 MiB 2.32 MiB 608.63 KiB
7597ded 1.73 MiB 2.32 MiB 609.88 KiB
4a9c176 1.73 MiB 2.33 MiB 612.69 KiB
3695453 1.73 MiB 2.32 MiB 611.62 KiB
7967d22 1.73 MiB 2.32 MiB 612.47 KiB
3695453 1.73 MiB 2.32 MiB 611.62 KiB
4a9c176 1.73 MiB 2.33 MiB 612.69 KiB
3695453 1.73 MiB 2.32 MiB 611.62 KiB
a04f788 1.73 MiB 2.32 MiB 609.88 KiB
16371c5 1.73 MiB 2.32 MiB 611.62 KiB

Previous results on branch: feat/remove-otel-agent-exporter-disable-config

Startup times

Revision Plain With Sentry Diff
ec2eafd 352.86 ms 388.00 ms 35.14 ms

App size

Revision Plain With Sentry Diff
ec2eafd 1.73 MiB 2.32 MiB 612.39 KiB

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2022

Codecov Report

Base: 80.03% // Head: 80.03% // No change to project coverage 👍

Coverage data is based on head (567d7e9) compared to base (34a8bfd).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2408   +/-   ##
=========================================
  Coverage     80.03%   80.03%           
  Complexity     3765     3765           
=========================================
  Files           301      301           
  Lines         14207    14207           
  Branches       1884     1884           
=========================================
  Hits          11371    11371           
  Misses         2092     2092           
  Partials        744      744           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -44,3 +44,25 @@ To enable debug logging for Sentry, please provide `SENTRY_DEBUG=true` as enviro
add `debug=true` to your `sentry.properties`.

To also show debug output for OpenTelemetry please add `-Dotel.javaagent.debug=true` to the command.

## Getting rid of exporter error messages
Copy link
Member

@romtsn romtsn Dec 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: should we have something in sentry.properties for that as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's basic OTEL config. so I guess it's not worth bloating our config with it.

@adinauer adinauer mentioned this pull request Dec 2, 2022
21 tasks
@adinauer adinauer merged commit ecf9680 into main Dec 2, 2022
@adinauer adinauer deleted the feat/remove-otel-agent-exporter-disable-config branch December 2, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants