Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not attach empty sentry-trace and baggage headers #2385

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Nov 22, 2022

📜 Description

Do not attach empty sentry-trace and baggage headers if span / transaction is a NoOp

NOTE: Some of the checks could be done earlier too (i.e. before creating the child span) but that would involve more restructuring of the code to still attach breadcrumbs.

💡 Motivation and Context

Fixes #2376

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2022

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 41586a4

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2022

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 431.20 ms 514.86 ms 83.66 ms
Size 1.73 MiB 2.32 MiB 610.45 KiB

@adinauer adinauer merged commit 57f2656 into feat/otel-propagator Nov 28, 2022
@adinauer adinauer deleted the feat/do-not-attach-empty-trace-and-baggage-headers branch November 28, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants