Add contexts to SentryTracer and add otel context to it #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adinauer
commented
Nov 15, 2022
| @@ -234,4 +234,19 @@ private SpanStatus mapOtelStatus(final @NotNull ReadableSpan otelSpan) { | |||
| private boolean hasSentryBeenInitialized() { | |||
| return Sentry.isEnabled(); | |||
| } | |||
|
|
|||
| private @NotNull Map<String, Object> toMapWithStringKeys(@Nullable Attributes attributes) { | |||
There was a problem hiding this comment.
JsonObjectSerializer only serializes Maps with String keys.
|
Performance metrics 🚀
|
Codecov ReportBase: 80.44% // Head: 80.44% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## feat/otel-span-processor #2361 +/- ##
==============================================================
- Coverage 80.44% 80.44% -0.01%
- Complexity 3692 3694 +2
==============================================================
Files 292 292
Lines 13777 13784 +7
Branches 1817 1817
==============================================================
+ Hits 11083 11088 +5
- Misses 1993 1995 +2
Partials 701 701
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
adinauer
requested review from
romtsn,
stefanosiano and
markushi
as code owners
romtsn
approved these changes
Nov 16, 2022
...try/sentry-opentelemetry-core/src/main/java/io/sentry/opentelemetry/SentrySpanProcessor.java
Outdated
Show resolved
Hide resolved
...try/sentry-opentelemetry-core/src/main/java/io/sentry/opentelemetry/SentrySpanProcessor.java
Outdated
Show resolved
Hide resolved
This was referenced Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
SentryTracernow has acontexts: Contextsattribute and methods to retrieve and add to contexts.💡 Motivation and Context
This allows us to attach OTEL attributes to the transaction context.
💚 How did you test it?
📝 Checklist
🔮 Next steps