-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump spring to 2.7.4 #2279
Bump spring to 2.7.4 #2279
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
54cebc8 | 300.86 ms | 341.43 ms | 40.57 ms |
7300956 | 337.57 ms | 384.21 ms | 46.64 ms |
3d89dea | 345.59 ms | 364.06 ms | 18.47 ms |
d4087ee | 278.00 ms | 313.86 ms | 35.86 ms |
2f079a1 | 296.91 ms | 337.43 ms | 40.51 ms |
c5ccd8a | 329.98 ms | 365.52 ms | 35.54 ms |
1e4690d | 354.69 ms | 387.88 ms | 33.19 ms |
7300956 | 324.20 ms | 353.79 ms | 29.58 ms |
3d89dea | 322.38 ms | 350.82 ms | 28.45 ms |
54cebc8 | 331.12 ms | 385.14 ms | 54.02 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
54cebc8 | 1.73 MiB | 2.29 MiB | 579.43 KiB |
7300956 | 1.73 MiB | 2.29 MiB | 578.69 KiB |
3d89dea | 1.74 MiB | 2.33 MiB | 604.92 KiB |
d4087ee | 1.73 MiB | 2.29 MiB | 579.50 KiB |
2f079a1 | 1.74 MiB | 2.33 MiB | 605.56 KiB |
c5ccd8a | 1.74 MiB | 2.33 MiB | 607.44 KiB |
1e4690d | 1.74 MiB | 2.33 MiB | 604.92 KiB |
7300956 | 1.73 MiB | 2.29 MiB | 578.69 KiB |
3d89dea | 1.74 MiB | 2.33 MiB | 604.92 KiB |
54cebc8 | 1.73 MiB | 2.29 MiB | 579.43 KiB |
Previous results on branch: feat/bump-spring-version
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6654d5d | 316.37 ms | 355.76 ms | 39.39 ms |
64f02c6 | 340.73 ms | 383.67 ms | 42.94 ms |
d85d3d4 | 288.60 ms | 321.00 ms | 32.40 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6654d5d | 1.73 MiB | 2.29 MiB | 579.50 KiB |
64f02c6 | 1.73 MiB | 2.29 MiB | 579.43 KiB |
d85d3d4 | 1.73 MiB | 2.29 MiB | 579.50 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing Changelog entry. Apart from that LGTM
@SuppressWarnings("deprecation") | ||
public class SecurityConfiguration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l
: A comment on why we need to suppress the warning would be nice.
Hmm something's weird here. I pushed the changelog (see https://github.com/getsentry/sentry-java/blame/da8b638abf10ce69d5803bb375109f5e166af624/CHANGELOG.md#L8) but it doesn't update the PR. Gonna wait a bit, maybe it just works later without me doing anything 🤞 |
Codecov ReportBase: 80.10% // Head: 80.10% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2279 +/- ##
=========================================
Coverage 80.10% 80.10%
Complexity 3423 3423
=========================================
Files 242 242
Lines 12692 12692
Branches 1698 1698
=========================================
Hits 10167 10167
Misses 1882 1882
Partials 643 643 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📜 Description
Should also get rid of dependabot warnings regarding vulnerable dependencies.
Note: we marked the dependencies as provided so we don't actually drag in old versions.
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps