Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make profiling rate defaults to 101 hz #2211

Merged
merged 7 commits into from
Aug 8, 2022
Merged

Conversation

stefanosiano
Copy link
Member

📜 Description

  1. Deprecated profilingTracesIntervalMillis option
  2. Added internal profilingTracesHz option
  3. Default profilingTracesHz is now 101, to avoid lockstep sampling

💡 Motivation and Context

  1. profilingTracesIntervalMillis should not be exposed to the user, at least for now
  2. We make reasoning in terms of profiling traces rate, so i added the profilingTracesHz option
  3. In order to make sure we avoid lockstep sampling i set it to 101 by default

💚 How did you test it?

Unit test to check profilingTracesIntervalMillis is ignored and profilingTracesHz is used, instead.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

stefanosiano and others added 4 commits August 5, 2022 18:05
added internal profilingTracesHz option
default profilingTracesHz is now 101, to avoid lockstep sampling
added internal profilingTracesHz option
default profilingTracesHz is now 101, to avoid lockstep sampling
added internal profilingTracesHz option
default profilingTracesHz is now 101, to avoid lockstep sampling
@stefanosiano stefanosiano marked this pull request as ready for review August 5, 2022 16:17
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2022

Codecov Report

Merging #2211 (0b265f5) into main (ba925d3) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2211   +/-   ##
=========================================
  Coverage     80.65%   80.65%           
  Complexity     3355     3355           
=========================================
  Files           240      240           
  Lines         12324    12324           
  Branches       1633     1633           
=========================================
  Hits           9940     9940           
  Misses         1778     1778           
  Partials        606      606           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -2,9 +2,16 @@

## Unreleased

### Fixes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah didn't notice the changelog was wrong on main

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, probably could even be when i merged another pr 😅. Not sure, though

@stefanosiano stefanosiano merged commit 7dd32c0 into main Aug 8, 2022
@stefanosiano stefanosiano deleted the feat/profiling-trace-hz branch August 8, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants