-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make profiling rate defaults to 101 hz #2211
Conversation
added internal profilingTracesHz option default profilingTracesHz is now 101, to avoid lockstep sampling
added internal profilingTracesHz option default profilingTracesHz is now 101, to avoid lockstep sampling
added internal profilingTracesHz option default profilingTracesHz is now 101, to avoid lockstep sampling
Codecov Report
@@ Coverage Diff @@
## main #2211 +/- ##
=========================================
Coverage 80.65% 80.65%
Complexity 3355 3355
=========================================
Files 240 240
Lines 12324 12324
Branches 1633 1633
=========================================
Hits 9940 9940
Misses 1778 1778
Partials 606 606 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@@ -2,9 +2,16 @@ | |||
|
|||
## Unreleased | |||
|
|||
### Fixes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah didn't notice the changelog was wrong on main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, probably could even be when i merged another pr 😅. Not sure, though
📜 Description
profilingTracesIntervalMillis
optionprofilingTracesHz
optionprofilingTracesHz
is now 101, to avoid lockstep sampling💡 Motivation and Context
profilingTracesIntervalMillis
should not be exposed to the user, at least for nowprofilingTracesHz
option💚 How did you test it?
Unit test to check
profilingTracesIntervalMillis
is ignored andprofilingTracesHz
is used, instead.📝 Checklist
🔮 Next steps