Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix start timestamp not set in ActivityLifecycleIntegration #2210

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Aug 5, 2022

#skip-changelog
Guess changelog is not needed since the bug hasn't been released yet

📜 Description

Messed up a refactoring

💡 Motivation and Context

Start timestamp was set after calling startTransaction so had no effect. This fixes it.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@adinauer adinauer requested a review from romtsn as a code owner August 5, 2022 16:00
@bruno-garcia
Copy link
Member

Test that validates the fix and avoid regression is advised

@adinauer
Copy link
Member Author

adinauer commented Aug 5, 2022

Test that validates the fix and avoid regression is advised

There are tests that validate the timestamp has been set, the problem is, it doesn't care whether the timestamp was set before or after calling startTransaction as long as it's set at the end of the test (which it still was).

@adinauer adinauer merged commit ba925d3 into main Aug 5, 2022
@adinauer adinauer deleted the fix/start-timestamp-not-set branch August 5, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants