Allow opting out of device info collection that requires Inter-Process Communication (IPC) #2100
Conversation
sentry-android-core/src/main/java/io/sentry/android/core/DefaultAndroidEventProcessor.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/ManifestMetadataReader.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #2100 +/- ##
=========================================
Coverage 80.94% 80.94%
Complexity 3254 3254
=========================================
Files 231 231
Lines 11952 11952
Branches 1586 1586
=========================================
Hits 9674 9674
Misses 1698 1698
Partials 580 580 Continue to review full report at Codecov.
|
…estMetadataReader.java Co-authored-by: Manoel Aranda Neto <[email protected]>
sentry-android-core/src/main/java/io/sentry/android/core/DefaultAndroidEventProcessor.java
Outdated
Show resolved
Hide resolved
| @@ -456,6 +462,25 @@ class DefaultAndroidEventProcessorTest { | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
| fun `Does not collect device info that requires IPC if disabled`() { | |||
There was a problem hiding this comment.
Would be good to check that by default (no change in SentryOptions) we do get the additional context
There was a problem hiding this comment.
@bruno-garcia we already had a test for that which does what you're asking right above this test. See https://github.com/getsentry/sentry-java/pull/2100/files#diff-47a15d06d787ba053ff683e5e72e2d105eac60e27127cb8938744247dd4f7593R443-R463
|
Lets include this in our next patch release to unblock a customer |
📜 Description
Allow opting out of device info collection that requires Inter-Process Communication (IPC)
💡 Motivation and Context
A way of avoiding #2095
💚 How did you test it?
📝 Checklist
🔮 Next steps