-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow optimization and obfuscation of the SDK by reducing proguard rules #2031
Conversation
Codecov Report
@@ Coverage Diff @@
## 6.x.x #2031 +/- ##
========================================
Coverage ? 81.06%
Complexity ? 3211
========================================
Files ? 229
Lines ? 11804
Branches ? 1568
========================================
Hits ? 9569
Misses ? 1650
Partials ? 585 Continue to review full report at Codecov.
|
@romtsn what's about |
Sorry I've been meaning to leave some comments here but got lost in testing the changes 😄 So I thought that we probably don't need |
@marandaneto should I approve it since I can't add you as a reviewer? 🤣 Also, this is what's kept at the moment (I think we did not miss anything and I gave it thorough testing, including bytecode manipulation stuff - still works, because it happens pre-R8 phase) |
This crashes on release builds on AGP 7.2.1 due to the NdkIntegration using reflection. |
Thanks for the report, would you mind raising a new issue with more context and stack trace? Thanks. |
Yeah we'd need more details - we explicitly keep |
Closes #1976