Feat: Allow setting SDK info (name & version) in manifest #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
approved these changes
May 3, 2022
There was a problem hiding this comment.
LGTM. Lets see what @marandaneto and @romtsn think about this
vaind
force-pushed
the
feat/sdk-info-setting
branch
2 times, most recently
from
8751608
to
5474694
Compare
9 tasks
romtsn
reviewed
May 4, 2022
sentry-android-core/src/main/java/io/sentry/android/core/ManifestMetadataReader.java
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/ManifestMetadataReader.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/test/java/io/sentry/android/core/ManifestMetadataReaderTest.kt
Outdated
Show resolved
Hide resolved
romtsn
approved these changes
May 4, 2022
vaind
force-pushed
the
feat/sdk-info-setting
branch
from
201b9ed
to
e3935e0
Compare
|
@vaind please target the |
marandaneto
reviewed
May 4, 2022
sentry-android-core/src/main/java/io/sentry/android/core/ManifestMetadataReader.java
Outdated
Show resolved
Hide resolved
vaind
force-pushed
the
feat/sdk-info-setting
branch
from
e3935e0
to
762751c
Compare
done |
vaind
force-pushed
the
feat/sdk-info-setting
branch
from
762751c
to
42c3ddf
Compare
Codecov Report
@@ Coverage Diff @@
## 6.x.x #2016 +/- ##
=========================================
Coverage 80.79% 80.79%
Complexity 3146 3146
=========================================
Files 228 228
Lines 11645 11645
Branches 1565 1565
=========================================
Hits 9409 9409
Misses 1649 1649
Partials 587 587 Continue to review full report at Codecov.
|
marandaneto
reviewed
May 5, 2022
vaind
force-pushed
the
feat/sdk-info-setting
branch
from
b437465
to
11e539c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Enables users to override the SDK info
💡 Motivation and Context
This allows other SDKs that use sentry-cocoa internally to identify the events. Enables getsentry/sentry-unity#616
💚 How did you test it?
Added a test case
📝 Checklist