Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Spring Boot dependency to 2.5.13 #2011

Merged
merged 2 commits into from
Apr 27, 2022
Merged

Conversation

maciejwalkowiak
Copy link
Contributor

📜 Description

Upgrade Spring Boot dependency to 2.5.13

💡 Motivation and Context

Fixes #2010

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

val springBootVersion = "2.4.4"
// Spring is currently not compatible with Kotlin 1.4
val springKotlinCompatibleLanguageVersion = "1.3"
val springBootVersion = "2.5.13"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a breaking change to folks? As in they'll be stuck on an older version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, similar to Logback and Log4j - we do not dictate the Spring Boot version used in user projects (as explained here #2010 (comment)). It only changes version used by us and as long as we don't use anything that got introduced in 2.5 we're good. Anyways, 2.4 reached end of life and all Spring Boot users are recommended to upgrade to >= 2.5

@adinauer
Copy link
Member

Do we also want this for 5.7.x?

@maciejwalkowiak maciejwalkowiak merged commit 875f4c9 into 6.x.x Apr 27, 2022
@maciejwalkowiak maciejwalkowiak deleted the upgrade-spring-boot branch April 27, 2022 07:13
@@ -6,6 +6,7 @@ Starting with version `6.6.0` of the `sentry`, [Sentry's version >= v21.9.0](htt

* Fix: Profiling rate decreased from 300hz to 100hz; fixed profiling traces folder creation on manual sdk init (#1997)
* Fix: Allow disabling sending of client reports via Android Manifest and external options (#2007)
* Ref: Upgrade Spring Boot dependency to 2.5.13 (#2011)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not require anything from users migrating to Sentry SDK 6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants