Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Allow disabling sending of client reports via Android Manifest and external options #2007

Merged
merged 2 commits into from
Apr 26, 2022

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Apr 25, 2022

📜 Description

Allow disabling sending of client reports via Android Manifest and external options.

💡 Motivation and Context

Fixes #2005

💚 How did you test it?

Unit Tests, Emulator, Spring Boot Demo

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@adinauer adinauer changed the base branch from main to 6.x.x April 25, 2022 14:34
@adinauer
Copy link
Member Author

adinauer commented Apr 25, 2022

Do we also want to allow disabling for log4j, logback etc.?

As discussed in todays daily, it's OK to use a properties file for them.

@marandaneto
Copy link
Contributor

marandaneto commented Apr 26, 2022

@adinauer missing the changelog entry.
Also, I'd recommend filling the PR template accordingly as well.
Thanks for doing this.

@marandaneto marandaneto changed the title Fix/allow disabling client reports Fix: Allow disabling sending of client reports via Android Manifest and external options Apr 26, 2022
@marandaneto
Copy link
Contributor

@adinauer Keep the PR title up to date with the changelog as well, thanks.

Freel free to merge and cut a 6.0.0-beta.1

@adinauer adinauer merged commit 4eb7640 into 6.x.x Apr 26, 2022
@adinauer adinauer deleted the fix/allow-disabling-client-reports branch April 26, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow disabling send client reports
2 participants