-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only send session update for dropped events if state changed #2002
Only send session update for dropped events if state changed #2002
Conversation
Codecov Report
@@ Coverage Diff @@
## fix/event-drop-session-update-inconsistencies #2002 +/- ##
===================================================================================
+ Coverage 80.77% 80.79% +0.01%
- Complexity 3131 3146 +15
===================================================================================
Files 228 228
Lines 11622 11642 +20
Branches 1556 1565 +9
===================================================================================
+ Hits 9388 9406 +18
- Misses 1648 1649 +1
- Partials 586 587 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…/event-drop-session-update-inconsistencies-extra
…/event-drop-session-update-inconsistencies-extra
…/event-drop-session-update-inconsistencies-extra
Co-authored-by: Manoel Aranda Neto <[email protected]>
Co-authored-by: Manoel Aranda Neto <[email protected]>
… github.com:getsentry/sentry-java into fix/event-drop-session-update-inconsistencies-extra
…/event-drop-session-update-inconsistencies-extra
... where the session update is not sent because it does not change the health of the sesssion
📜 Description
Extra for #2001 to only send session update for dropped events if session state changed (healty -> errored or errored -> crashed).
💡 Motivation and Context
See linked PR for more context. This should ensure session updates make it to the server for dropped events that changed the session state.
💚 How did you test it?
📝 Checklist
🔮 Next steps