Fix: If transaction or span is finished, do not allow to mutate #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romtsn
approved these changes
Mar 8, 2022
bruno-garcia
reviewed
Mar 9, 2022
| @@ -379,6 +415,10 @@ public void setName(@NotNull String name) { | |||
| @Deprecated | |||
| @ApiStatus.ScheduledForRemoval | |||
| public void setRequest(final @Nullable Request request) { | |||
| if (root.isFinished()) { | |||
| return; | |||
There was a problem hiding this comment.
Should we log a warning? It seems like an incorrect instrumentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fix: If transaction or span is finished, do not allow to mutate
💡 Motivation and Context
Closes #1840
💚 How did you test it?
📝 Checklist
🔮 Next steps