Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options.printUncaughtStackTrace #1890

Merged
merged 9 commits into from
Feb 2, 2022
Merged

Conversation

Paxa
Copy link
Contributor

@Paxa Paxa commented Jan 31, 2022

Adds

options.printUncaughtStackTrace

#1077

@Paxa
Copy link
Contributor Author

Paxa commented Jan 31, 2022

I use thrown.printStackTrace because most of the time I don't enable sentry logger

Wdyt how it will be better?

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2022

Codecov Report

Merging #1890 (4082197) into main (46929b0) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1890      +/-   ##
============================================
+ Coverage     75.39%   75.42%   +0.03%     
- Complexity     2239     2244       +5     
============================================
  Files           225      225              
  Lines          8015     8026      +11     
  Branches        850      852       +2     
============================================
+ Hits           6043     6054      +11     
  Misses         1562     1562              
  Partials        410      410              
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/SentryOptions.java 86.43% <100.00%> (+0.33%) ⬆️
...io/sentry/UncaughtExceptionHandlerIntegration.java 76.62% <100.00%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46929b0...4082197. Read the comment docs.

@marandaneto
Copy link
Contributor

@Paxa please add a changelog entry :)

@Paxa
Copy link
Contributor Author

Paxa commented Feb 1, 2022

please add a changelog entry

done (also added a test)

@Paxa
Copy link
Contributor Author

Paxa commented Feb 2, 2022

@romtsn it prints stack trace to stderr

@marandaneto marandaneto changed the title Add options.printUncaughtStackTrace #1077 Add options.printUncaughtStackTrace Feb 2, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
@romtsn
Copy link
Member

romtsn commented Feb 2, 2022

@romtsn it prints stack trace to stderr

indeed, thanks for spotting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants