Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add breadcrumbs auto-capturing for UI events #1876

Merged
merged 26 commits into from
Jan 21, 2022

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jan 18, 2022

📜 Description

  • Adds a custom GestureListener and Window.Callback that auto-capture breadcrumbs for UI events (clicks, swipes, etc.)

Current limitations

  • onMenuItemClicks are not supported
  • Clicks inside DialogFragments are not supported (probably can be an option for FragmentLifecycleIntegration or just a new integration)
  • Swipes for ViewPager and ViewPager2 are not supported (a new integration, since those are new deps?)
  • RecyclerView is partially supported (the click on an item will be captured, but there's no useful data like which position in the list was selected - again, a new integration?)

Closes #1412

💡 Motivation and Context

Cus this looks beautiful
image

💚 How did you test it?

Manually

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

:shipit:

@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2022

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against f1de272

@romtsn romtsn marked this pull request as draft January 18, 2022 22:05
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a lot of background on how this works but left a few thoughts hoping to help out

…res/SentryGestureListener.java

Co-authored-by: Bruno Garcia <[email protected]>
@romtsn romtsn marked this pull request as ready for review January 20, 2022 23:16
@romtsn
Copy link
Member Author

romtsn commented Jan 20, 2022

Ready for final review

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto
Copy link
Contributor

@romtsn once this is merged, please update the 6.x.x branch with the main branch, which might have conflicts that you'd solve better.

@romtsn romtsn merged commit f44c6cf into main Jan 21, 2022
@romtsn romtsn deleted the feat/ui-events-breadcrumbs branch January 21, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add UI events as breadcrumbs for Android
3 participants