-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Relax TransactionNameProvider. #1861
Conversation
Turn TransactionNameProvider into an interface enabling using SentryTracingFilter with other MVC frameworks like Grails or JAX-RS.
Codecov Report
@@ Coverage Diff @@
## 6.x.x #1861 +/- ##
============================================
- Coverage 80.69% 80.68% -0.01%
Complexity 2897 2897
============================================
Files 214 214
Lines 10674 10682 +8
Branches 1399 1399
============================================
+ Hits 8613 8619 +6
- Misses 1565 1566 +1
- Partials 496 497 +1
Continue to review full report at Codecov.
|
@maciejwalkowiak please merge 6.x.x into your branch, I will be moving 6.0.0 forward. |
How could I use SentryTracingFilter in grails 2 ? |
Since we do not provide official support for Grails 2 (it's like 10 years old?) I can only give some hints:
If you are not able to use servlet filters, you will likely need to create custom Grails filter as explained in Grails 2.2. docs and you can use |
📜 Description
Turn TransactionNameProvider into an interface enabling using SentryTracingFilter with other MVC frameworks like Grails or JAX-RS.
💡 Motivation and Context
💚 How did you test it?
Unit & Integration tests
📝 Checklist
For great majority of users it's not a breaking change. It is breaking only because the
SentryTracingFilter
secondary constructor takes now an interface instead of a class.