Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add runtime classes for FileReader/FileWriter instrumentation #1843

Merged
merged 35 commits into from
Dec 14, 2021

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Dec 13, 2021

📜 Description

  • Added SentryFileReader implementation for FileReader instrumentation
  • Added SentryFileWriter implementation for FileWriter instrumentation

💡 Motivation and Context

This is a supporting PR with runtime classes for File I/O instrumentation s

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2021

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against bf506e5

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2021

Codecov Report

Merging #1843 (94b2ba8) into main (4c1cf85) will decrease coverage by 0.13%.
The diff coverage is 20.00%.

❗ Current head 94b2ba8 differs from pull request most recent head bf506e5. Consider uploading reports for the commit bf506e5 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1843      +/-   ##
============================================
- Coverage     75.61%   75.47%   -0.14%     
- Complexity     2237     2239       +2     
============================================
  Files           223      225       +2     
  Lines          7969     7989      +20     
  Branches        846      846              
============================================
+ Hits           6026     6030       +4     
- Misses         1533     1549      +16     
  Partials        410      410              
Impacted Files Coverage Δ
.../sentry/instrumentation/file/SentryFileWriter.java 16.66% <16.66%> (ø)
.../sentry/instrumentation/file/SentryFileReader.java 25.00% <25.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c1cf85...bf506e5. Read the comment docs.

Base automatically changed from feat/file-io-stream-instr to main December 13, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants