Fix: Do not crash when event processors throw a lower level Throwable class #1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitsandfoxes
approved these changes
Nov 11, 2021
romtsn
approved these changes
Nov 11, 2021
…s://github.com/getsentry/sentry-java into fix/android-perf-processor-abstractmethoderror
marandaneto
deleted the
fix/android-perf-processor-abstractmethoderror
branch
| @@ -235,7 +235,7 @@ private SentryTransaction processTransaction( | |||
| for (final EventProcessor processor : eventProcessors) { | |||
| try { | |||
| transaction = processor.process(transaction, hint); | |||
| } catch (Exception e) { | |||
There was a problem hiding this comment.
Do we have other places in the codebase we should make this change?
| * Returns the event itself | ||
| * | ||
| * @param event the SentryEvent the SentryEvent | ||
| * @param hint the Hint the Hint |
There was a problem hiding this comment.
indeed, it was auto-generated, didn't realize the confusion :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fix: Do not crash when event processors throw a lower level Throwable class
💡 Motivation and Context
getsentry/sentry-unity#398
💚 How did you test it?
running it on newer Unity versions
📝 Checklist
🔮 Next steps