Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: unregister UncaughtExceptionHandler on close. #1770

Merged
merged 2 commits into from
Oct 18, 2021
Merged

Conversation

maciejwalkowiak
Copy link
Contributor

📜 Description

Fix: unregister UncaughtExceptionHandler on close.

💡 Motivation and Context

Fixes #1767

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

@maciejwalkowiak maciejwalkowiak marked this pull request as ready for review October 18, 2021 10:27
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2021

Codecov Report

Merging #1770 (7386858) into main (b2eb278) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1770   +/-   ##
=========================================
  Coverage     75.31%   75.32%           
  Complexity     2165     2165           
=========================================
  Files           215      215           
  Lines          7718     7717    -1     
  Branches        822      821    -1     
=========================================
  Hits           5813     5813           
  Misses         1507     1507           
+ Partials        398      397    -1     
Impacted Files Coverage Δ
.../main/java/io/sentry/UncaughtExceptionHandler.java 100.00% <ø> (ø)
...io/sentry/UncaughtExceptionHandlerIntegration.java 76.00% <100.00%> (+1.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2eb278...7386858. Read the comment docs.

@marandaneto marandaneto merged commit a001bbf into main Oct 18, 2021
@marandaneto marandaneto deleted the gh-1767 branch October 18, 2021 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentry.close() should remove Thread UncaughtExceptionHandler
3 participants