Fix: ActivityLifecycleIntegration#appStartSpan memory leak #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
requested review from
bruno-garcia and
maciejwalkowiak
as code owners
marandaneto
requested review from
philipphofmann and
a team
and removed request for
philipphofmann and
bruno-garcia
Codecov Report
@@ Coverage Diff @@
## main #1732 +/- ##
=========================================
Coverage 75.19% 75.19%
Complexity 2126 2126
=========================================
Files 212 212
Lines 7606 7606
Branches 807 807
=========================================
Hits 5719 5719
Misses 1496 1496
Partials 391 391 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fix: ActivityLifecycleIntegration#appStartSpan memory leak
💡 Motivation and Context
#1731
💚 How did you test it?
unit test and leak canary
📝 Checklist
🔮 Next steps