Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Should not capture unfinished transaction #1719

Merged
merged 2 commits into from
Sep 15, 2021
Merged

Conversation

maciejwalkowiak
Copy link
Contributor

@maciejwalkowiak maciejwalkowiak commented Sep 15, 2021

📜 Description

Should not capture unfinished transaction.

💡 Motivation and Context

Fixes #1704

💚 How did you test it?

Unit tests.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

@maciejwalkowiak maciejwalkowiak marked this pull request as ready for review September 15, 2021 09:00
@codecov-commenter
Copy link

Codecov Report

Merging #1719 (9eba4eb) into main (7cd5740) will not change coverage.
The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1719   +/-   ##
=========================================
  Coverage     75.04%   75.04%           
  Complexity     2099     2099           
=========================================
  Files           211      211           
  Lines          7514     7514           
  Branches        791      791           
=========================================
  Hits           5639     5639           
  Misses         1492     1492           
  Partials        383      383           
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/Hub.java 74.17% <58.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cd5740...9eba4eb. Read the comment docs.

@maciejwalkowiak maciejwalkowiak merged commit d71704e into main Sep 15, 2021
@maciejwalkowiak maciejwalkowiak deleted the gh-1704 branch September 15, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should not capture unfinished transaction
3 participants