Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Move tags from transaction.contexts.trace.tags to transaction.tags #1700

Merged
merged 3 commits into from
Sep 6, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

@maciejwalkowiak maciejwalkowiak commented Sep 6, 2021

📜 Description

Move tags from transaction.contexts.trace.tags to transaction.tags.

💡 Motivation and Context

Fixes #1693

The implementation could be cleaner - like introducing a dedicated TraceContext object, but this would mean we introduce a breaking change - something to keep in mind for 6.0.

💚 How did you test it?

Unit tests.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

@maciejwalkowiak maciejwalkowiak marked this pull request as ready for review September 6, 2021 08:58
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2021

Codecov Report

Merging #1700 (de6be68) into main (717ccad) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1700      +/-   ##
============================================
+ Coverage     74.80%   74.90%   +0.10%     
- Complexity     2077     2081       +4     
============================================
  Files           210      210              
  Lines          7430     7445      +15     
  Branches        782      783       +1     
============================================
+ Hits           5558     5577      +19     
+ Misses         1491     1487       -4     
  Partials        381      381              
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/SpanContext.java 93.75% <100.00%> (+0.56%) ⬆️
...ain/java/io/sentry/protocol/SentryTransaction.java 92.50% <100.00%> (+2.84%) ⬆️
sentry/src/main/java/io/sentry/SentryTracer.java 89.20% <0.00%> (+1.43%) ⬆️
sentry/src/main/java/io/sentry/Span.java 95.08% <0.00%> (+3.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 717ccad...de6be68. Read the comment docs.

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment but rather than that LGTM, thanks @maciejwalkowiak

@maciejwalkowiak maciejwalkowiak merged commit 40adcb2 into main Sep 6, 2021
@maciejwalkowiak maciejwalkowiak deleted the gh-1693 branch September 6, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transaction.contexts.trace.tags should go under transaction.tags
3 participants