-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update proguard keep rule for enums #1694
Conversation
thanks for doing this @romankivalin |
Codecov Report
@@ Coverage Diff @@
## main #1694 +/- ##
=========================================
Coverage 75.93% 75.93%
Complexity 2025 2025
=========================================
Files 207 207
Lines 7060 7060
Branches 699 699
=========================================
Hits 5361 5361
Misses 1361 1361
Partials 338 338 Continue to review full report at Codecov.
|
We would really appreciate it if you could notify everyone about this in similar situations in the future. Mistakes happen, but please-please try to reach out to your users. |
@dmytroKarataiev the change is part of our changelog, how would you suggest then? |
@marandaneto an email would be the best, or a notification on the sentry like an outdated dependency notification but with an exclamation mark that there is a critical issue. |
@dmytroKarataiev thanks for the feedback, I will discuss that internally. |
📜 Description
Updated proguard rule to target library enums only.
💡 Motivation and Context
This is a consumer proguard file, which means it is included into consumer application proguard config, and if we target
*
, it will apply to each class of consumer application too. This unreasonably prevents obfuscation of consumer application enums.Fixes #1684
💚 How did you test it?
Didn't test.
📝 Checklist
I think it's a breaking change because consumer application could accidentally rely on this rule, and removing it may break obfucated code.
🔮 Next steps