Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more convenient way to pass BeforeSpanCallback in OpenFeign integration. #1637

Merged
merged 2 commits into from
Aug 11, 2021
Merged

Add more convenient way to pass BeforeSpanCallback in OpenFeign integration. #1637

merged 2 commits into from
Aug 11, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

📜 Description

Add more convenient way to pass BeforeSpanCallback in OpenFeign integration.

💡 Motivation and Context

There was no way to pass BeforeSpanCallback without passing also a Hub.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@maciejwalkowiak maciejwalkowiak marked this pull request as ready for review August 9, 2021 20:04
@maciejwalkowiak maciejwalkowiak merged commit d41f73b into main Aug 11, 2021
@maciejwalkowiak maciejwalkowiak deleted the feign-polish branch August 11, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marandaneto marandaneto marandaneto approved these changes

@bruno-garcia bruno-garcia Awaiting requested review from bruno-garcia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maciejwalkowiak @marandaneto