Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenFeign support. #1632

Merged
merged 5 commits into from
Aug 3, 2021
Merged

Add OpenFeign support. #1632

merged 5 commits into from
Aug 3, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

📜 Description

Add OpenFeign support.

💡 Motivation and Context

#1628

💚 How did you test it?

Unit & integration tests.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

Update reference docs.

@codecov-commenter
Copy link

Codecov Report

Merging #1632 (e762529) into main (bb9f248) will increase coverage by 0.13%.
The diff coverage is 92.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1632      +/-   ##
============================================
+ Coverage     75.63%   75.76%   +0.13%     
- Complexity     2006     2017      +11     
============================================
  Files           204      206       +2     
  Lines          6980     7036      +56     
  Branches        692      699       +7     
============================================
+ Hits           5279     5331      +52     
- Misses         1365     1367       +2     
- Partials        336      338       +2     
Impacted Files Coverage Δ
...ain/java/io/sentry/openfeign/SentryCapability.java 71.42% <71.42%> (ø)
...in/java/io/sentry/openfeign/SentryFeignClient.java 95.91% <95.91%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb9f248...e762529. Read the comment docs.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bruno-garcia bruno-garcia merged commit 1afa86e into main Aug 3, 2021
@bruno-garcia bruno-garcia deleted the gh-1628 branch August 3, 2021 21:32
@bruno-garcia
Copy link
Member

@maciejwalkowiak we'll need to add this to https://github.com/getsentry/sentry-release-registry and also to .craft.yml in this repo. Is that something you can help with too?

@marandaneto marandaneto mentioned this pull request Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants