Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Do not throw IAE when tracing header contain invalid trace id. #1605

Merged
merged 2 commits into from
Jul 16, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

📜 Description

Fix: Do not throw IAE when tracing header contain invalid trace id.

💡 Motivation and Context

Fixes #1604

💚 How did you test it?

Unit tests

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

@maciejwalkowiak maciejwalkowiak marked this pull request as ready for review July 15, 2021 11:07
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2021

Codecov Report

Merging #1605 (23d4e84) into main (4407b37) will increase coverage by 0.04%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1605      +/-   ##
============================================
+ Coverage     76.02%   76.07%   +0.04%     
- Complexity     1974     1976       +2     
============================================
  Files           198      198              
  Lines          6837     6842       +5     
  Branches        680      680              
============================================
+ Hits           5198     5205       +7     
+ Misses         1306     1305       -1     
+ Partials        333      332       -1     
Impacted Files Coverage Δ
.../io/sentry/spring/tracing/SentryTracingFilter.java 81.57% <0.00%> (ø)
...try/src/main/java/io/sentry/SentryTraceHeader.java 96.00% <100.00%> (+0.54%) ⬆️
...y/exception/InvalidSentryTraceHeaderException.java 83.33% <100.00%> (+8.33%) ⬆️
...try/src/main/java/io/sentry/protocol/SentryId.java 92.59% <0.00%> (+7.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4407b37...23d4e84. Read the comment docs.

@marandaneto marandaneto merged commit fb12011 into main Jul 16, 2021
@marandaneto marandaneto deleted the gh-1604 branch July 16, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tracing functionality's SentryId.fromStringSentryId() throws IAE, causing 500 Internal Server error
3 participants