Make SentryAppender non-final for Log4j2 and Logback (#1602) #1603
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Make SentryAppender non-final for Log4j2 and Logback
💡 Motivation and Context
Users will be able to customize the appenders it if they need it. See #1602
💚 How did you test it?
Did a full build (I had to disable OutboxSenderTest class,
deserialize sample envelope with event and two attachments
test, SentryWebfluxIntegrationTest (due to an Error while closing the hub), but I believe those are not related to to my changes at all.📝 Checklist
🔮 Next steps