-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assign lastEventId only if event was queued for submission #1565
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1565 +/- ##
============================================
+ Coverage 76.02% 76.03% +0.01%
- Complexity 1953 1955 +2
============================================
Files 192 192
Lines 6760 6765 +5
Branches 676 675 -1
============================================
+ Hits 5139 5144 +5
Misses 1294 1294
Partials 327 327
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better call it 'queue for submission' or similar since it can still be dropped due to date limiting, beforeSend, eventProcessor or some error
Co-authored-by: Bruno Garcia <[email protected]>
📜 Description
Assign lastEventId only if event has been sent successfully
💡 Motivation and Context
Fixes #1414
💚 How did you test it?
📝 Checklist