Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign lastEventId only if event was queued for submission #1565

Merged
merged 4 commits into from
Jun 28, 2021
Merged

Conversation

maciejwalkowiak
Copy link
Contributor

📜 Description

Assign lastEventId only if event has been sent successfully

💡 Motivation and Context

Fixes #1414

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2021

Codecov Report

Merging #1565 (e52cb68) into main (007cf3d) will increase coverage by 0.01%.
The diff coverage is 92.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1565      +/-   ##
============================================
+ Coverage     76.02%   76.03%   +0.01%     
- Complexity     1953     1955       +2     
============================================
  Files           192      192              
  Lines          6760     6765       +5     
  Branches        676      675       -1     
============================================
+ Hits           5139     5144       +5     
  Misses         1294     1294              
  Partials        327      327              
Impacted Files Coverage Δ
...racing/SentrySpanClientHttpRequestInterceptor.java 0.00% <0.00%> (ø)
...java/io/sentry/spring/SentryExceptionResolver.java 100.00% <100.00%> (ø)
sentry/src/main/java/io/sentry/DateUtils.java 92.59% <100.00%> (-0.52%) ⬇️
sentry/src/main/java/io/sentry/Hub.java 73.00% <100.00%> (ø)
sentry/src/main/java/io/sentry/Scope.java 93.27% <100.00%> (+0.06%) ⬆️
...y/src/main/java/io/sentry/protocol/SentrySpan.java 96.29% <100.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ceccb11...e52cb68. Read the comment docs.

@bruno-garcia bruno-garcia changed the title Assign lastEventId only if event has been sent successfully Assign lastEventId only if event was queued for submission Jun 25, 2021
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better call it 'queue for submission' or similar since it can still be dropped due to date limiting, beforeSend, eventProcessor or some error

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Bruno Garcia <[email protected]>
CHANGELOG.md Outdated Show resolved Hide resolved
@marandaneto marandaneto merged commit e7fb5c3 into main Jun 28, 2021
@marandaneto marandaneto deleted the gh-1414 branch June 28, 2021 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assign lastEventId only if we were able to send the event
4 participants