Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref: Deprecate cacheDirSize and add maxCacheItems #1499

Merged
merged 3 commits into from
May 31, 2021

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented May 31, 2021

📜 Description

Ref: Deprecate cacheDirSize and add maxCacheItems

💡 Motivation and Context

Fix #1162

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2021

Codecov Report

Merging #1499 (1cd4d7f) into main (5f14002) will decrease coverage by 0.03%.
The diff coverage is 54.54%.

❗ Current head 1cd4d7f differs from pull request most recent head 8d4cae2. Consider uploading reports for the commit 8d4cae2 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1499      +/-   ##
============================================
- Coverage     76.03%   76.00%   -0.04%     
  Complexity     1924     1924              
============================================
  Files           191      191              
  Lines          6661     6664       +3     
  Branches        663      663              
============================================
  Hits           5065     5065              
- Misses         1271     1274       +3     
  Partials        325      325              
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/SentryOptions.java 84.45% <42.85%> (-0.78%) ⬇️
...y/src/main/java/io/sentry/cache/EnvelopeCache.java 48.82% <75.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f14002...8d4cae2. Read the comment docs.

@marandaneto marandaneto merged commit dbc59e2 into main May 31, 2021
@marandaneto marandaneto deleted the ref/max-cache-items branch May 31, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate cachDirSize and add maxCacheItems
3 participants