Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace clone() with copy constructor #1496

Merged
merged 5 commits into from
May 31, 2021
Merged

Replace clone() with copy constructor #1496

merged 5 commits into from
May 31, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

📜 Description

Replace clone() with copy constructor

💡 Motivation and Context

Fixes #1482

💚 How did you test it?

Unit tests.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2021

Codecov Report

Merging #1496 (871cddb) into main (5dd8324) will increase coverage by 0.37%.
The diff coverage is 93.75%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1496      +/-   ##
============================================
+ Coverage     75.66%   76.03%   +0.37%     
+ Complexity     1929     1924       -5     
============================================
  Files           191      191              
  Lines          6600     6661      +61     
  Branches        666      663       -3     
============================================
+ Hits           4994     5065      +71     
+ Misses         1280     1271       -9     
+ Partials        326      325       -1     
Impacted Files Coverage Δ
...try/src/main/java/io/sentry/protocol/Contexts.java 82.60% <63.63%> (ø)
sentry/src/main/java/io/sentry/Breadcrumb.java 92.30% <90.90%> (+0.30%) ⬆️
sentry/src/main/java/io/sentry/SpanContext.java 93.18% <91.66%> (+1.28%) ⬆️
sentry/src/main/java/io/sentry/Scope.java 93.21% <94.44%> (+0.06%) ⬆️
sentry/src/main/java/io/sentry/Hub.java 73.33% <100.00%> (+0.45%) ⬆️
sentry/src/main/java/io/sentry/SentryClient.java 87.22% <100.00%> (+1.05%) ⬆️
sentry/src/main/java/io/sentry/Stack.java 97.29% <100.00%> (+7.05%) ⬆️
sentry/src/main/java/io/sentry/protocol/App.java 97.22% <100.00%> (+0.67%) ⬆️
...ntry/src/main/java/io/sentry/protocol/Browser.java 100.00% <100.00%> (ø)
...entry/src/main/java/io/sentry/protocol/Device.java 99.24% <100.00%> (+0.20%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dd8324...871cddb. Read the comment docs.

@maciejwalkowiak maciejwalkowiak marked this pull request as ready for review May 28, 2021 12:11
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace clone() with copy constructor
4 participants