Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Measure app start time #1487

Merged
merged 23 commits into from
Jun 11, 2021
Merged

Feat: Measure app start time #1487

merged 23 commits into from
Jun 11, 2021

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented May 25, 2021

📜 Description

Feat: App start metric

💡 Motivation and Context

extract from #1466

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

CHANGELOG.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 25, 2021

Codecov Report

Merging #1487 (c43cb3e) into main (97c6a66) will decrease coverage by 0.11%.
The diff coverage is 63.15%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1487      +/-   ##
============================================
- Coverage     76.12%   76.00%   -0.12%     
- Complexity     1934     1942       +8     
============================================
  Files           191      192       +1     
  Lines          6696     6721      +25     
  Branches        666      668       +2     
============================================
+ Hits           5097     5108      +11     
- Misses         1274     1287      +13     
- Partials        325      326       +1     
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/HubAdapter.java 5.17% <0.00%> (-0.10%) ⬇️
sentry/src/main/java/io/sentry/NoOpHub.java 48.71% <0.00%> (-1.29%) ⬇️
sentry/src/main/java/io/sentry/NoOpSpan.java 30.00% <0.00%> (-1.58%) ⬇️
...entry/src/main/java/io/sentry/NoOpTransaction.java 20.68% <0.00%> (-0.74%) ⬇️
sentry/src/main/java/io/sentry/Sentry.java 42.06% <0.00%> (-0.59%) ⬇️
...main/java/io/sentry/protocol/MeasurementValue.java 0.00% <0.00%> (ø)
sentry/src/main/java/io/sentry/IHub.java 90.47% <50.00%> (-4.53%) ⬇️
...ain/java/io/sentry/protocol/SentryTransaction.java 86.20% <50.00%> (-2.69%) ⬇️
sentry/src/main/java/io/sentry/Hub.java 73.20% <66.66%> (-0.13%) ⬇️
sentry/src/main/java/io/sentry/Span.java 90.56% <87.50%> (-1.44%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97c6a66...c43cb3e. Read the comment docs.

@marandaneto marandaneto marked this pull request as ready for review May 25, 2021 12:25
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first pass. Looks already pretty good. 👍

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are still missing tests validating the span creation of the ActivityLifecycleIntegration.

Nice seeing this going forward 🚀.

@marandaneto marandaneto changed the title Feat: App start metric Feat: Measure app start time Jun 10, 2021
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done 👍

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adapting my suggested changes for the tests. 👍
LGTM 🚀

@marandaneto marandaneto merged commit 4af15fa into main Jun 11, 2021
@marandaneto marandaneto deleted the feat/app-start-metric branch June 11, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants