-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Measure app start time #1487
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1487 +/- ##
============================================
- Coverage 76.12% 76.00% -0.12%
- Complexity 1934 1942 +8
============================================
Files 191 192 +1
Lines 6696 6721 +25
Branches 666 668 +2
============================================
+ Hits 5097 5108 +11
- Misses 1274 1287 +13
- Partials 325 326 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first pass. Looks already pretty good. 👍
sentry-android-core/src/main/java/io/sentry/android/core/ActivityLifecycleIntegration.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/ActivityLifecycleIntegration.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/AppStartState.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/AppStartState.java
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/AppStartState.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/test/java/io/sentry/android/core/AppStartStateTest.kt
Outdated
Show resolved
Hide resolved
sentry-android-core/src/test/java/io/sentry/android/core/AppStartStateTest.kt
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/PerformanceAndroidEventProcessor.java
Outdated
Show resolved
Hide resolved
...ry-android-core/src/test/java/io/sentry/android/core/PerformanceAndroidEventProcessorTest.kt
Show resolved
Hide resolved
sentry-android-core/src/test/java/io/sentry/android/core/SentryPerformanceProviderTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are still missing tests validating the span creation of the ActivityLifecycleIntegration
.
Nice seeing this going forward 🚀.
sentry-android-core/src/main/java/io/sentry/android/core/PerformanceAndroidEventProcessor.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/PerformanceAndroidEventProcessor.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/AppStartState.java
Show resolved
Hide resolved
...ry-android-core/src/test/java/io/sentry/android/core/PerformanceAndroidEventProcessorTest.kt
Show resolved
Hide resolved
sentry-android-core/src/test/java/io/sentry/android/core/SentryPerformanceProviderTest.kt
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/ActivityLifecycleIntegration.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/ActivityLifecycleIntegration.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/PerformanceAndroidEventProcessor.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/AppStartState.java
Show resolved
Hide resolved
sentry-android-core/src/test/java/io/sentry/android/core/SentryPerformanceProviderTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost done 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adapting my suggested changes for the tests. 👍
LGTM 🚀
📜 Description
Feat: App start metric
💡 Motivation and Context
extract from #1466
💚 How did you test it?
📝 Checklist
🔮 Next steps