-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coroutines support #1479
Add coroutines support #1479
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1479 +/- ##
============================================
- Coverage 75.66% 75.65% -0.01%
- Complexity 1926 1929 +3
============================================
Files 190 191 +1
Lines 6590 6598 +8
Branches 666 666
============================================
+ Hits 4986 4992 +6
- Misses 1278 1280 +2
Partials 326 326
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my perspective LGTM!
We could get feedback from folks that have been interested in this before shipping though.
And validate that question whether it's OK to have 1 package with ktx + the coroutines, or if it's going to be a problem for too many ppl
@maciejwalkowiak I've created the docs issue as well getsentry/sentry-docs#3628 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, thanks @maciejwalkowiak
LGTM
I am trying to add support for sentry coroutine in the Spring Boot project given i am using implementation but its throwing error
|
please use this version for now https://github.com/getsentry/sentry-java/releases/tag/5.0.0-beta.7, 5.0.0 isn't out yet |
cant find |
@iamkdblue please raise a new issue with your setup and what you're trying to do, it'd be easier to track it down and fix it if there are issues, thanks |
Tested this out in 5.0.1 but it doesn't seem to work. Using this with the grpc-kotlin support and providing a Using |
@markallanson please raise a new issue with more detailed context, happy to look into it, thanks |
I got to the bottom of this, the sentry-spring-boot-starter wasn't initialising sentry before the |
@markallanson so was it a bug in your end or what, does it mean you're creating the |
@marandaneto I need to try and get the |
📜 Description
Adds the ability to use Sentry scope with Kotlin coroutines through a coroutines context element
SentryContext
.💡 Motivation and Context
Fixes #973.
💚 How did you test it?
Unit tests.
📝 Checklist
🔮 Next steps
It would be nice if someone with coroutines experience review it.