Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename: Rename enableSessionTracking to enableAutoSessionTracking #1457

Merged
merged 6 commits into from
May 3, 2021

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented May 3, 2021

📜 Description

Rename: Rename enableSessionTracking to enableAutoSessionTracking

💡 Motivation and Context

Fixes #1189

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

CHANGELOG.md Outdated Show resolved Hide resolved
@marandaneto
Copy link
Contributor Author

marandaneto commented May 3, 2021

@ueman and @jennmueng we'd need to change that on RN, Flutter and Cordova should use the new setter

@codecov-commenter
Copy link

codecov-commenter commented May 3, 2021

Codecov Report

Merging #1457 (8b82491) into main (e73d236) will decrease coverage by 0.03%.
The diff coverage is 16.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1457      +/-   ##
============================================
- Coverage     75.87%   75.83%   -0.04%     
  Complexity     1901     1901              
============================================
  Files           189      189              
  Lines          6499     6502       +3     
  Branches        640      640              
============================================
  Hits           4931     4931              
- Misses         1272     1275       +3     
  Partials        296      296              
Impacted Files Coverage Δ Complexity Δ
sentry/src/main/java/io/sentry/SentryOptions.java 85.18% <16.66%> (-0.80%) 136.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5696370...8b82491. Read the comment docs.

@marandaneto
Copy link
Contributor Author

@ueman and @jennmueng we'd need to change that on RN, Flutter and Cordova should use the new setter

please create an issue so we don't forget :)

@marandaneto marandaneto merged commit 1602f79 into main May 3, 2021
@marandaneto marandaneto deleted the rename/enableAutoSessionTracking branch May 3, 2021 15:09
jennmueng added a commit to getsentry/sentry-react-native that referenced this pull request May 17, 2021
Bumps sentry-android to 5.0.0-beta.3 and handles the breaking change to enableAutoSessionTracking: getsentry/sentry-java#1457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename 'enableSessionTracking' to 'enableAutoSessionTracking'
3 participants