Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Set Span status for OkHttp integration #1447

Merged
merged 4 commits into from
Apr 28, 2021
Merged

Fix: Set Span status for OkHttp integration #1447

merged 4 commits into from
Apr 28, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

📜 Description

Fix: Set Span status for OkHttp integration

💡 Motivation and Context

Fixes #1421

💚 How did you test it?

Unit tests.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

@maciejwalkowiak maciejwalkowiak marked this pull request as ready for review April 28, 2021 11:56
@codecov-commenter
Copy link

Codecov Report

Merging #1447 (332d77f) into main (a33afef) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 332d77f differs from pull request most recent head c4ad843. Consider uploading reports for the commit c4ad843 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1447      +/-   ##
============================================
- Coverage     75.88%   75.87%   -0.02%     
- Complexity     1889     1901      +12     
============================================
  Files           187      189       +2     
  Lines          6453     6499      +46     
  Branches        633      640       +7     
============================================
+ Hits           4897     4931      +34     
- Misses         1261     1272      +11     
- Partials        295      296       +1     
Impacted Files Coverage Δ Complexity Δ
...n/java/io/sentry/spring/boot/SentryProperties.java 76.66% <0.00%> (-4.82%) 9.00% <0.00%> (+1.00%) ⬇️
...entry/spring/SentryUserProviderEventProcessor.java 96.55% <0.00%> (ø) 12.00% <0.00%> (ø%)
...c/main/java/io/sentry/spring/SentryUserFilter.java 92.85% <0.00%> (ø) 10.00% <0.00%> (?%)
...entry/spring/SpringSecuritySentryUserProvider.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...io/sentry/spring/boot/SentryAutoConfiguration.java 98.18% <0.00%> (+0.18%) 1.00% <0.00%> (ø%)
.../io/sentry/spring/tracing/SentryTracingFilter.java 81.57% <0.00%> (+5.26%) 7.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a33afef...c4ad843. Read the comment docs.

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maciejwalkowiak maciejwalkowiak merged commit 1efaee2 into main Apr 28, 2021
@maciejwalkowiak maciejwalkowiak deleted the gh-1421 branch April 28, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Span status for OkHttp integration
3 participants