-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Run event processors and enrich transactions with contexts #1430
Conversation
sentry-spring/src/main/java/io/sentry/spring/SentryUserProviderEventProcessor.java
Outdated
Show resolved
Hide resolved
@bruno-garcia can we discuss this? |
sentry-android-core/src/main/java/io/sentry/android/core/DefaultAndroidEventProcessor.java
Outdated
Show resolved
Hide resolved
@bruno-garcia @maciejwalkowiak please review |
Codecov Report
@@ Coverage Diff @@
## main #1430 +/- ##
============================================
+ Coverage 75.84% 75.88% +0.04%
- Complexity 1870 1889 +19
============================================
Files 186 187 +1
Lines 6405 6453 +48
Branches 639 633 -6
============================================
+ Hits 4858 4897 +39
- Misses 1258 1261 +3
- Partials 289 295 +6
Continue to review full report at Codecov.
|
@maciejwalkowiak could you please check that I didn't break anything in the backend integrations for error monitoring and performance? thanks |
sentry-spring/src/test/kotlin/io/sentry/spring/SentryUserProviderEventProcessorTest.kt
Outdated
Show resolved
Hide resolved
As mentioned on Discord, unfortunately event processing for transactions doesn't save us from having a user filter. When transaction is finished, user is cleared from the thread local already. I'll now just double check if nothing is off with the integrations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than these small things mentioned above, LGTM
📜 Description
Fix: Run event processors and enrich transactions with contexts
💡 Motivation and Context
Event processors were not run for transactions, so contexts were missing.
Some contexts are heavy for Android, hence there's a flag to not do IO nor IPC if it's a transaction.
Spring User is also run, hence transactions for the Spring integration will contain the user info.
Some fields from Event were moved to BaseEvent so transactions contain more data like breadcrumbs, extra, etc...
💚 How did you test it?
running and unit tests
📝 Checklist
🔮 Next steps