Fix: set scope on transaction #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
reviewed
Apr 15, 2021
| @@ -521,6 +490,37 @@ public void captureSession(final @NotNull Session session, final @Nullable Objec | |||
| return event; | |||
| } | |||
|
|
|||
| private <T extends SentryBaseEvent> T applyScope( | |||
| final @NotNull T sentryBaseEvent, final @Nullable Scope scope) { | |||
There was a problem hiding this comment.
there's already a NPE check to call this method, hence Scope can be non null
There was a problem hiding this comment.
For the transaction we use this method directly, that's why it's kept as nullable.
marandaneto
approved these changes
Apr 16, 2021
|
Converting back to draft, since we need first to marge event processing on transactions. |
Wrong PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fix: set scope on transaction
💡 Motivation and Context
Until now, only request has been set from the scope on transaction.
💚 How did you test it?
Unit tests
📝 Checklist
🔮 Next steps
I believe applying scope deserves a refactoring. We can add a method on
SentryBaseEvent#applyScope(scope)which will get overwritten inSentryTransactionandSentryEvent.