Refactor converting HttpServletRequest to Sentry Request in Spring integration. #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gered during request execution.
…dy in SentrySpringRequestListener.
marandaneto
reviewed
Apr 12, 2021
sentry-spring/src/test/kotlin/io/sentry/spring/SentrySpringRequestListenerTest.kt
Outdated
Show resolved
Hide resolved
marandaneto
reviewed
Apr 12, 2021
sentry-spring/src/test/kotlin/io/sentry/spring/SentrySpringRequestListenerTest.kt
Outdated
Show resolved
Hide resolved
marandaneto
reviewed
Apr 14, 2021
| @@ -171,6 +173,7 @@ This release brings the Sentry Performance feature to Java SDK, Spring, Spring B | |||
| * Enhancement: Add the ability to register multiple OptionsConfiguration beans (#1093) | |||
| * Fix: Append DebugImage list if event already has it | |||
| * Fix: Sort breadcrumbs by Date if there are breadcrumbs already in the event | |||
| * Feat: Database query tracing with datasource-proxy (#1095) | |||
There was a problem hiding this comment.
this was reverted, should not be here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Convert HttpServletRequest to Sentry Request once for all events triggered during request execution.
💡 Motivation and Context
Currently conversion from HttpServletRequest to Sentry request happens for each event in the event processor. With this change we do it only once. Also as a result, there is no need to set the request on the scope in the
SentryTracingFilter.💚 How did you test it?
📝 Checklist