-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Avoid NPE when MDC contains null values #1385
Conversation
@wreulicke why is it a follow-up of #1364 ? doesn't #1364 fix the issue at all? |
@marandaneto |
I just noticed its pretty much the same fix but for sentry-jul, that was the issue, I thought you were just fixing the same issue for sentry-logback :) mind writing a unit test? thanks |
Co-authored-by: Manoel Aranda Neto <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1385 +/- ##
============================================
+ Coverage 75.68% 75.72% +0.03%
- Complexity 1858 1861 +3
============================================
Files 185 185
Lines 6363 6368 +5
Branches 636 637 +1
============================================
+ Hits 4816 4822 +6
Misses 1258 1258
+ Partials 289 288 -1
Continue to review full report at Codecov.
|
I have written the unit test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
all good, thanks for the contribution @wreulicke |
📜 Description
Avoid NPE when MDC contains null values
Follow up #1364
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps