Upgrade Apache HttpComponents Core to 5.0.3. #1375
Conversation
HttpComponents Core 5.0.3 contains a bugfix for a potential infinite loop and CPU exhaustion.
| api(Config.Libs.apacheHttpCore) | ||
| api(Config.Libs.apacheHttpCoreH2) |
There was a problem hiding this comment.
do people need to access its classes? otherwise only implementation is fine
There was a problem hiding this comment.
They don't need to but they may want to. We bring ApacheTransportFactory but they may want to create their custom factory with custom client configuration. I am not 100% sure if at some level of configuration they would not need to use lower level classes.
|
Converting to draft until we decide that this is the way to go. The alternative is to upgrade httpcomponents-core directly to 5.1 |
if 5.0.3 fixes the bug, even though they said 5.1 is also compatible, not sure how extensible this has been tested as its a new release, it'd be safer just bumping the patch. |
|
5.0.3 fixes a bug, but i am not sure if this is the one we were facing. Just to double check I've filed an issue: https://issues.apache.org/jira/browse/HTTPCLIENT-2146 |
`Instructions and example for changelog`$
To the changelog entry, please add a link to this PR (consider a more descriptive message):` - Upgrade Apache HttpComponents Core to 5.0.3(#1375)
|
📜 Description
Upgrade Apache HttpComponents Core to 5.0.3.
💡 Motivation and Context
HttpComponents Core 5.0.3 contains a bugfix for a potential infinite loop and CPU exhaustion.
According to library authors, HttpComponents Core 5.0.3 is compatible with HttpComponents Client 5.0.3.
💚 How did you test it?
Covered by existing tests. Could not reproduce the infinite loop.
📝 Checklist