Allow inheritance of SentryHandler class in sentry-jul package #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing final keyword on sentry-jul SentryHandler class
|
@davyrod thanks for the contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Removing final keyword on sentry-jul SentryHandler class to allow inheritance for the creation of custom log handlers based on SentryHandler.
💡 Motivation and Context
Allows extension of SentryHandler to create custom LogHandlers that can be deployed to EE application servers like Glassfish/Payara.
Fixes #1360
💚 How did you test it?
Ran local tests
📝 Checklist
🔮 Next steps