-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraalVM Native Image Compatibility. #1329
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1329 +/- ##
=========================================
Coverage 75.64% 75.64%
Complexity 1842 1842
=========================================
Files 185 185
Lines 6319 6319
Branches 626 626
=========================================
Hits 4780 4780
Misses 1254 1254
Partials 285 285
Continue to review full report at Codecov.
|
sentry/src/main/resources/META-INF/native-image/io.sentry/sentry/reflect-config.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving blindly as I know nothing about GraalVM compatibility :D
To be fair I am also not an expert in this subject. I think it is a step forward and definitely it makes it work with GraalVM but I am not sure if it covers it all. I hope we will get feedback once its there. |
📜 Description
GraalVM Native Image Compatibility.
💡 Motivation and Context
Fixes #1323.
Partially fixes #1324 - error reporting works with performance there is one gotcha - it does not work with
@SentrySpan
and@SentryTransaction
annotations. Since Spring Native is evolving project potentially it may handle this use case in the future without our custom code. I'll sync with Spring team about it but this can be anyway solved in separate PR.💚 How did you test it?
Building native image with Spring Native and Quarkus and checked if no exceptions are thrown in runtime and if errors sent to Sentry have complete information.
📝 Checklist
🔮 Next steps
On the side in meantime work on Spring Native integration to handle properly
@SentrySpan
and@SentryTransaction
annotations.