Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Initialize Sentry in Logback appender when DSN is not set in XML config #1296

Merged
merged 3 commits into from
Feb 26, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

📜 Description

Initialize Sentry in Logback appender when DSN is not set in XML config

💡 Motivation and Context

Fixes #1295

With the recent change, when DSN is set using external properties, Sentry would fail to initialize.

💚 How did you test it?

Unit tests.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@codecov-io
Copy link

codecov-io commented Feb 26, 2021

Codecov Report

Merging #1296 (18b3490) into main (12c7ff7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1296      +/-   ##
============================================
+ Coverage     75.67%   75.68%   +0.01%     
- Complexity     1786     1787       +1     
============================================
  Files           183      183              
  Lines          6207     6207              
  Branches        622      622              
============================================
+ Hits           4697     4698       +1     
  Misses         1231     1231              
+ Partials        279      278       -1     
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/io/sentry/logback/SentryAppender.java 89.74% <100.00%> (+1.28%) 23.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12c7ff7...18b3490. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SENTRY_DSN environment variable not picked up automatically anymore
3 participants