Prevent NoOpHub from creating heavy SentryOptions objects. #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejwalkowiak
requested review from
bruno-garcia and
marandaneto
as code owners
marandaneto
reviewed
Feb 18, 2021
| * @param empty if options should be empty. | ||
| */ | ||
| private SentryOptions(final boolean empty) { | ||
| if (!empty) { |
There was a problem hiding this comment.
I think the heaviest objects are inited. directly during the field declaration, maybe we should move all of them here in the ctor, so we can really do a cheap ctor.
There was a problem hiding this comment.
The most heavy part is MainEventProcessor with HostnameCache that spins up a thread and SentryExecutorService. The rest is mainly no-op, except the serializer but i am not sure if it makes sense to complicate it any further.
marandaneto
approved these changes
Feb 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Prevent NoOpHub from creating heavy SentryOptions objects.
💡 Motivation and Context
Fixes #1263
💚 How did you test it?
📝 Checklist