Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SentryExceptionResolver should not send handled errors by default #1248

Merged
merged 4 commits into from
Feb 16, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

📜 Description

Change the default SentryExceptionResolver behavior to not send errors handled with Spring exception handlers.

💡 Motivation and Context

I believe current default behavior of SentryExceptionResolver is surprising for users - even if they define an exception handler for an exception - to handle it gracefully - it's still being sent to Sentry as an error. This PR changes the default behavior (that can still be overwritten through setting exception-resolver-order) to send only unhandled exceptions.

💚 How did you test it?

Integration tests

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

While it does not break the compilation process, it is a breaking change from the behavior point of view.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a considerable change in behavior, would be nice to bump a minor here and add a big note on the top of the release notes (the GitHub one)

@maciejwalkowiak maciejwalkowiak merged commit a13796d into main Feb 16, 2021
@maciejwalkowiak maciejwalkowiak deleted the spring-exception-resolver-order branch February 16, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants