SentryExceptionResolver should not send handled errors by default #1248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Change the default SentryExceptionResolver behavior to not send errors handled with Spring exception handlers.
💡 Motivation and Context
I believe current default behavior of
SentryExceptionResolver
is surprising for users - even if they define an exception handler for an exception - to handle it gracefully - it's still being sent to Sentry as an error. This PR changes the default behavior (that can still be overwritten through settingexception-resolver-order
) to send only unhandled exceptions.💚 How did you test it?
Integration tests
📝 Checklist
🔮 Next steps
While it does not break the compilation process, it is a breaking change from the behavior point of view.