Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @SentrySpan and @SentryTransaction on classes and interfaces. #1243

Merged
merged 2 commits into from
Feb 10, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

📜 Description

Adds support for @SentrySpan and @SentryTransaction on classes and interfaces.

💡 Motivation and Context

Fixes #1232.

💚 How did you test it?

Unit & Integration test, sample app.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

@codecov-io
Copy link

codecov-io commented Feb 10, 2021

Codecov Report

Merging #1243 (46dd27e) into main (a64fae7) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1243      +/-   ##
============================================
+ Coverage     74.64%   74.68%   +0.03%     
- Complexity     1715     1720       +5     
============================================
  Files           177      180       +3     
  Lines          6039     6047       +8     
  Branches        599      601       +2     
============================================
+ Hits           4508     4516       +8     
  Misses         1257     1257              
  Partials        274      274              
Impacted Files Coverage Δ Complexity Δ
...io/sentry/spring/boot/SentryAutoConfiguration.java 97.77% <100.00%> (-0.19%) 1.00 <0.00> (ø)
...ntry/spring/tracing/SentryAdviceConfiguration.java 100.00% <100.00%> (ø) 5.00 <5.00> (?)
...ava/io/sentry/spring/tracing/SentrySpanAdvice.java 93.10% <100.00%> (+0.79%) 7.00 <0.00> (+1.00)
...pring/tracing/SentrySpanPointcutConfiguration.java 100.00% <100.00%> (ø) 2.00 <2.00> (?)
...try/spring/tracing/SentryTracingConfiguration.java 100.00% <100.00%> (ø) 1.00 <1.00> (-6.00)
...sentry/spring/tracing/SentryTransactionAdvice.java 90.62% <100.00%> (+1.33%) 9.00 <0.00> (+1.00)
...racing/SentryTransactionPointcutConfiguration.java 100.00% <100.00%> (ø) 2.00 <2.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a64fae7...46dd27e. Read the comment docs.

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice addition, thanks for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support @SentrySpan and @SentryTransaction for interfaces
3 participants